Merged
Conversation
Signed-off-by: IonutMuthi <Ionut.Muthi@analog.com>
Signed-off-by: IonutMuthi <Ionut.Muthi@analog.com>
bindea-cristian
requested changes
Mar 18, 2026
Signed-off-by: IonutMuthi <Ionut.Muthi@analog.com>
AlexandraTrifan
approved these changes
Mar 23, 2026
Contributor
|
@bindea-cristian please review this again so we can merge it |
AlexandraTrifan
requested changes
Mar 23, 2026
Contributor
AlexandraTrifan
left a comment
AlexandraTrifan
left a comment
There was a problem hiding this comment.
Line 201 in c9e4dc2
https://github.com/analogdevicesinc/scopy/blob/c9e4dc21173c39984351955473706abb149b0f58/CMakeLists.txt#L180C4-L180C18
The ENABLE_SCOPYJS is defined in pluginbase, here: https://github.com/analogdevicesinc/scopy/blame/c9e4dc21173c39984351955473706abb149b0f58/pluginbase/CMakeLists.txt#L60 .
The main CMake first uses the enable_scopyjs and then includes the subdirectory that creates this option. does this properly work?
Signed-off-by: IonutMuthi <Ionut.Muthi@analog.com>
bindea-cristian
approved these changes
Mar 30, 2026
AlexandraTrifan
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.